Add showErrorWhenFocused and fix wrong renderbox size #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tkko
reviewed
Mar 13, 2025
| @@ -390,6 +392,9 @@ class Pinput extends StatefulWidget { | |||
| /// If true [errorPinTheme] will be applied and [errorText] will be displayed under the Pinput | |||
| final bool forceErrorState; | |||
|
|
|||
| /// If true, the error will also be displayed in the focused state. Otherwise the error is not displayed in the focused state. | |||
| final bool showErrorWhenFocused; | |||
There was a problem hiding this comment.
Can't you use the forceErrorState instead?
There was a problem hiding this comment.
The default behavior of a normal text field is that the error is displayed even when the user focuses on the field.
In theory, I could also use forceErrorState, but then I would need to handle focus checks manually.
From my perspective, this approach is much easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.