chore: make _path optional and more representative #4303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfdking
force-pushed
the
rough_making_model_node_optional
branch
from
4b06000 to
7caa5fa
Compare
benfdking
changed the title
benfdking
force-pushed
the
rough_making_model_node_optional
branch
from
7caa5fa to
ac68e4c
Compare
benfdking
force-pushed
the
rough_making_model_node_optional
branch
from
aab1108 to
b7be02d
Compare
benfdking
changed the title
benfdking
commented
Jun 12, 2025
benfdking
force-pushed
the
rough_making_model_node_optional
branch
from
b7be02d to
f25a7ee
Compare
benfdking
force-pushed
the
rough_making_model_node_optional
branch
2 times, most recently
from
99d0f86 to
7055cb5
Compare
- more correctly represent path being optional
benfdking
force-pushed
the
rough_making_model_node_optional
branch
from
7055cb5 to
98b2d25
Compare
| @@ -2171,6 +2173,8 @@ def load_sql_based_model( | |||
| # The name of the model will be inferred from its path relative to `models/`, if it's not explicitly specified | |||
| name = meta_fields.pop("name", "") | |||
| if not name and infer_names: | |||
| if path is None: | |||
| raise ValueError("Model must have a name", path) | |||
There was a problem hiding this comment.
why is the path included, given that it's None. the string message should be enough
| @@ -207,6 +207,8 @@ def _convert_models( | |||
|
|
|||
| if model.kind.is_seed: | |||
| # this will produce the original seed file, eg "items.csv" | |||
| if model._path is None: | |||
| raise ValueError(f"Unhandled model path: {model._path}") | |||
There was a problem hiding this comment.
again in these I'm confused about the inclusion of model._path in the error message when it's none
| return models.Model( | ||
| name=model.name, | ||
| fqn=model.fqn, | ||
| path=str(model._path.absolute().relative_to(context.path).as_posix()), | ||
| full_path=str(model._path.absolute().as_posix()), | ||
| path=str(path.absolute().relative_to(context.path).as_posix()) if path else None, |
There was a problem hiding this comment.
in line 125 you check for none and raise so here there is no need for a check as the path should exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the path type is slightly confusing. Models can exist without a Path. Rather than mark the
_pathproperty asNonewe callPath()which is equivalent to callingPath(".")which is not particularly indicative it just returns your path tocwd. Optional is a much better representation.