Chore/add prettier #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-ogilvie
commented
May 13, 2019
| @@ -0,0 +1 @@ | |||
| dist/* | |||
There was a problem hiding this comment.
This disables linting errors in code editors for built files.
a-ogilvie
commented
May 13, 2019
| * > 0 means decimals, < 0 means powers of 10 | ||
| * | ||
| * | ||
| * @return {number} - The number, rounded |
a-ogilvie
commented
May 13, 2019
| "regression", | ||
| "data", | ||
| "fiting", | ||
| "fitting", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds prettier to the codebase. Prettier is an opinionated code formatter, and it has gained popularity quickly. It allows a consistent style to be enforced, without too much infighting over what that style should be.
The approach I've taken here is to configure Prettier so the smallest number of changes occurred - this is what lead to the
.prettierrcfile committed.Feel free to push back and debate this change: #92