-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jellyfin audiobook download #1208
Draft
lysanntranvouez
wants to merge
45
commits into
TortugaPower:develop
Choose a base branch
from
lysanntranvouez:feature/jellyfin-download
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Jellyfin audiobook download #1208
lysanntranvouez
wants to merge
45
commits into
TortugaPower:develop
from
lysanntranvouez:feature/jellyfin-download
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
very basic UX
seems like we need to pass the userID to the /UserViews request, else we get item IDs for them, that cannot be used to retrieve their images
so that progress is visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a feature "Download from Jellyfin", similar to "Download from URL".
Related tasks
Approach
Things to be aware of / Things to focus on
Draft status
This is still very much a draft at this stage:
Other missing things before I consider this ready for merge:
Super optional but nice to have:
Screenshots
Simulator recording of an earlier version:
https://github.com/user-attachments/assets/1ad1fe56-5d6a-4314-93e8-583229090d4a