fix(engineio): fix Noop packet emission when upgrading transport
#554
+75
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
added
C-Bug
Totodore
force-pushed
the
fix-upgrade-process
branch
from
dacad0f to
2b70ab4
Compare
Totodore
added a commit
that referenced
this pull request
Aug 7, 2025
Totodore
added a commit
that referenced
this pull request
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Until now the
Nooppacket was sent only one time on the connection and through the internal buffer channel between transports and the engine.io socket. This led to a bug in the upgrade mechanism because the client could send multiple polling requests during the upgrade process.Solution
Per the official socket.io implementation in JS, the
Nooppacket should be sent only from the HTTP handler for the polling request in the socket is in an "upgrading" state. With this solution, every polling call are immediately closed during the upgrade mechanism.Fixes #497