Fix CellWonEvent being unable to be acted upon. #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run at LOWEST no plugin could act on the CellWonEvent without cancelling the event and then re-firing it (and potentially not getting it in before FlagWar operates off of it anyways.) This change makes the FW plugin act upon its own CellWonEvent on MONITOR priority, after other plugins have had their chance at listening/cancelling it on all of the other, lower priorities. Closes #405.
inaaeon
pushed a commit
to inaaeon/FlagWar
that referenced
this pull request
Apr 13, 2025
When run at LOWEST no plugin could act on the CellWonEvent without cancelling the event and then re-firing it (and potentially not getting it in before FlagWar operates off of it anyways.) This change makes the FW plugin act upon its own CellWonEvent on MONITOR priority, after other plugins have had their chance at listening/cancelling it on all of the other, lower priorities. Closes TownyAdvanced#405.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description:
When run at LOWEST no plugin could act on the CellWonEvent without cancelling the event and then re-firing it (and potentially not getting it in before FlagWar operates off of it anyways.)
Changes:
This change makes the FW plugin act upon its own CellWonEvent on MONITOR priority, after other plugins have had their chance at listening/cancelling it on all of the other, lower priorities.
Relevant FlagWar Issue tickets:
Closes #405.
By making this pull request, I represent that I have read and agree to release my own changes that I
have submitted under the terms of the accompanying license (Apache-2.0). I guarantee that these
changes are mine and are not encumbered by any other license or restriction to the best of my
knowledge.