Skip to content

Remove duplicated deno deploy env variables#1362

Merged
aaronmondal merged 1 commit intoTraceMachina:mainfrom
SchahinRohani:fix/web-workflow
Sep 26, 2024
Merged

Remove duplicated deno deploy env variables#1362
aaronmondal merged 1 commit intoTraceMachina:mainfrom
SchahinRohani:fix/web-workflow

Conversation

@SchahinRohani
Copy link
Contributor

@SchahinRohani SchahinRohani commented Sep 25, 2024

Description

The deno deploy variables --org and --project are already set in the web workflow

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Contributor

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained, and all files reviewed

@aaronmondal aaronmondal merged commit c17cc34 into TraceMachina:main Sep 26, 2024
@SchahinRohani SchahinRohani deleted the fix/web-workflow branch September 26, 2024 23:45
MarcusSorealheis pushed a commit to MarcusSorealheis/nativelink that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants