Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated deno deploy env variables #1362

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Remove duplicated deno deploy env variables #1362

merged 1 commit into from
Sep 26, 2024

Conversation

SchahinRohani
Copy link
Contributor

@SchahinRohani SchahinRohani commented Sep 25, 2024 •
edited by allada
Loading

Description

The deno deploy variables --org and --project are already set in the web workflow

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

aaronmondal
aaronmondal approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained, and all files reviewed

@aaronmondal aaronmondal merged commit c17cc34 into TraceMachina:main Sep 26, 2024
30 checks passed
@SchahinRohani SchahinRohani deleted the fix/web-workflow branch September 26, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmondal aaronmondal aaronmondal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchahinRohani @aaronmondal