Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bikeshed {Store, Scheduler}Config -> {Store, Scheduler}Spec #1483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bikeshed {Store, Scheduler}Config -> {Store, Scheduler}Spec #1483

wants to merge 1 commit into from

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Nov 17, 2024 •
edited by allada
Loading

This non-functional change simplifies the naming for the configuration from "Config" to "Spec". This makes it clearer when we operate on Store implementations and configuration fragments. The new naming scheme is also closer aligned with common K8s intuition and a bit shorter to type.

This change is Reviewable

aaronmondal
aaronmondal commented Nov 17, 2024
View reviewed changes
Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@adam-singer +@allada +@SchahinRohani

Reviewable status: 0 of 3 LGTMs obtained, and 0 of 43 files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, Web Platform Deployment / ubuntu-24.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @adam-singer, @allada, and @SchahinRohani)

@aaronmondal
Bikeshed {Store, Scheduler}Config -> {Store, Scheduler}Spec
e683892 
This non-functional change simplifies the naming for the configuration
from "Config" to "Spec". This makes it clearer when we operate on Store
implementations and configuration fragments. The new naming scheme is
also closer aligned with common K8s intuition and a bit shorter to type.
@MarcusSorealheis
Copy link
Collaborator

I think we can agree that we should delay spending a lot of cycles on this PR until we solve other more important priorities, cc @bclark8923

@MarcusSorealheis
Copy link
Collaborator

lol @ "bikeshed" reference. That's what it is, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adam-singer adam-singer

@allada allada

@SchahinRohani SchahinRohani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aaronmondal @MarcusSorealheis @adam-singer @allada @SchahinRohani