Skip to content

extend scheduler factory to support Mongo store #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

extend scheduler factory to support Mongo store #1843

wants to merge 1 commit into from

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Jun 27, 2025 •
edited
Loading

Description

Modifying the scheduler factory to ensure that MongoDB could be an alternative to Redis.

Fixes # (issue)

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

MarcusSorealheis
MarcusSorealheis commented Jun 27, 2025
View reviewed changes
nativelink-scheduler/src/default_scheduler_factory.rs
let store = store
.into_inner()
.as_any_arc()
.downcast::<ExperimentalMongoStore>()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This downcast is causing some problems and I'm trying to figure out. I'm confident that Mongo can present a more usable option for some customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palfrey palfrey Awaiting requested review from palfrey

@chrisstaite-menlo chrisstaite-menlo Awaiting requested review from chrisstaite-menlo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarcusSorealheis