Skip to content

Add debug helpers to check LRE kustomization#1857

Merged
palfrey merged 2 commits intoTraceMachina:mainfrom
palfrey:lre-debug-helpers
Jul 10, 2025
Merged

Add debug helpers to check LRE kustomization#1857
palfrey merged 2 commits intoTraceMachina:mainfrom
palfrey:lre-debug-helpers

Conversation

@palfrey
Copy link
Member

@palfrey palfrey commented Jul 4, 2025

Description

Mostly trying to aid debugging the build issues with #1848

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Github :)

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@palfrey palfrey force-pushed the lre-debug-helpers branch from 2877a32 to 516381a Compare July 6, 2025 21:59
@palfrey palfrey marked this pull request as ready for review July 7, 2025 09:41
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

@MarcusSorealheis
Copy link
Collaborator

Do we need lre at all? What does it give us exactly that the other workflows do not? No one uses it and as far as I understand, it was never complete.

@palfrey palfrey merged commit ba1cd53 into TraceMachina:main Jul 10, 2025
35 checks passed
@palfrey palfrey deleted the lre-debug-helpers branch July 10, 2025 09:55
MarcusSorealheis pushed a commit to MarcusSorealheis/nativelink that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants