Skip to content

Add debug helpers to check LRE kustomization #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Add debug helpers to check LRE kustomization #1857

merged 2 commits into from
Jul 10, 2025

Conversation

palfrey
Copy link
Member

@palfrey palfrey commented Jul 4, 2025 •
edited
Loading

Description

Mostly trying to aid debugging the build issues with #1848

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Github :)

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@palfrey palfrey force-pushed the lre-debug-helpers branch from 9ae780f to ccb32b2 Compare July 4, 2025 14:09
@palfrey palfrey force-pushed the lre-debug-helpers branch from 251f5c1 to 3d4faf4 Compare July 5, 2025 20:09
@palfrey palfrey force-pushed the lre-debug-helpers branch from 3d4faf4 to 2877a32 Compare July 5, 2025 21:06
@palfrey palfrey force-pushed the lre-debug-helpers branch from 2877a32 to 516381a Compare July 6, 2025 21:59
@palfrey palfrey marked this pull request as ready for review July 7, 2025 09:41
MarcusSorealheis
MarcusSorealheis approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

@MarcusSorealheis
Copy link
Collaborator

Do we need lre at all? What does it give us exactly that the other workflows do not? No one uses it and as far as I understand, it was never complete.

@palfrey palfrey merged commit ba1cd53 into TraceMachina:main Jul 10, 2025
35 checks passed
@palfrey palfrey deleted the lre-debug-helpers branch July 10, 2025 09:55
amankrx pushed a commit to amankrx/nativelink that referenced this pull request Jul 11, 2025
@palfrey @amankrx
Add debug helpers to check LRE kustomization (TraceMachina#1857)
4ea63b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusSorealheis MarcusSorealheis MarcusSorealheis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palfrey @MarcusSorealheis