Modified approach to Fix Zero Byte Uploads #1860
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
had a problem deploying
to
production
GitHub Actions
Error
MarcusSorealheis
had a problem deploying
to
production
GitHub Actions
Error
MarcusSorealheis
force-pushed
the
bugfix/drop-zero-byte-gcs
branch
from
d25131d to
87bacf0
Compare
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
|
Maybe we can do a simple upload at the beginning for a zero byte uploads. The problem appears to be that the loop breaks without initializing the upload session. So, a simple zero-byte upload in the beginning should solve this issue. |
amankrx
reviewed
Jul 10, 2025
|
|
||
| Ok(()) | ||
| } | ||
| // I'll delete this but it did not actually test and prevent the issue we were addressing. |
There was a problem hiding this comment.
I'm assuming this is working as expected right?
The problem appears to be during zero byte uploads. The get operation should work fine in this case.
Let me test this out locally as well.
MarcusSorealheis
changed the title
MarcusSorealheis
force-pushed
the
bugfix/drop-zero-byte-gcs
branch
from
87bacf0 to
5b0cbd5
Compare
MarcusSorealheis
had a problem deploying
to
production
GitHub Actions
Failure
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
had a problem deploying
to
production
GitHub Actions
Failure
amankrx
reviewed
Jul 10, 2025
| .err_tip(|| "Could not convert max_retry_buffer_size to u64")?, | ||
| ); | ||
|
|
||
| // Special case for known zero-byte uploads: Start resumable and finalize immediately. |
There was a problem hiding this comment.
Why do a resumable upload if the exact size is zero. Wouldn't it be better to do a simple upload for a zero byte uploads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@chrisstaite reported issues with the zero bytes and the GCS store. I'm trying to understand why this wasn't resolved bya. previous test to address it.
Fixes # (issue)
Type of change
How Has This Been Tested?
I wrote a test. It needs to be tested on a live GCP instance. I'm currently on a plane with limited bandwidth.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is