READY: Updated mypy CI check to install dependencies #8191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
upd_mypy_install_reqs
branch
from
142226f
to
a991174
Compare
qstokkink
force-pushed
the
upd_mypy_install_reqs
branch
from
6082776
to
417ce08
Compare
qstokkink
changed the title
qstokkink
changed the title
qstokkink
commented
Oct 4, 2024
| elif (guessed_type := mimetypes.guess_type(path)[0]) is not None: | ||
| response.content_type = guessed_type | ||
| else: | ||
| response.content_type = "application/octet-stream" |
There was a problem hiding this comment.
This is new behavior: instead of crashing when mimetypes.guess_type returns None, Tribler now uses an octet stream file type.
egbertbouman
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8189
This PR:
mypyworkflow to install Tribler dependencies before type-checking.