Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ubuntu 20.04 for building #8252

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

egbertbouman
Copy link
Member

Fixes #8242.

I removed cpio=2.13+dfsg-7 since it isn't needed nor is version 2.13+dfsg-7 available on Ubuntu 20.04.

@egbertbouman egbertbouman marked this pull request as ready for review November 11, 2024 10:14
qstokkink
qstokkink previously approved these changes Nov 11, 2024
Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified on my Ubuntu 24.04 that this works.

IIRC cpio, alien and rpm were necessary for the cx_Freeze build process before it used makedist_debian.sh, maybe the other two are also unnecessary now.

@synctext
Copy link
Member

Work on Ubuntu 20.04 👍

@egbertbouman
Copy link
Member Author

validate

@egbertbouman
Copy link
Member Author

Turns out the alien and rpm dependencies were needed after all (or al least one of them is..).
The only change is I made is an apt-get update which seemed to be needed.

Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking 👍

@egbertbouman egbertbouman merged commit eed451c into Tribler:main Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

gtk-4.0 required for Tribler 8.0 on Ubuntu LTS 20.04.06
3 participants