Fix share access to attachments for notes protected by login:password

[x1arch]

Split this PR: #7759

I faced with issue, browser do not sent Authorization header for pictures and attachments. I added cookie based authorization and query based authorization (for browsers with disabled cookies), could be configured by label

• Added new attribute #shareExclude for exclude note from share totally, implemented for remove scripts from share.
• Added new attribute #shareTemplateNoPrevNext for hide bottom prev next navigation.
• Added new attribute #shareTemplateNoLeftPanel for hide left panel totally.
• Added new attribute #shareContentAccess for manually setup content access auth, default is cookie. Bould be basic / query / cookie.
• Added new attribute #shareAccessTokenTimeout for manually configure token expiration timeout in seconds. (default value is 10 minutes)
• Updated readme, dev section

Token lives in the note, I use one token for multiple access, otherwise the token will overrides by every request and users will interfere with each other.

[gemini-code-assist]

Summary of Changes

Hello @x1arch, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the sharing functionality for notes protected by credentials, specifically by improving how attachments and other embedded content are accessed. It introduces flexible authentication mechanisms using cookies or query parameters to ensure secure delivery of content, alongside new configuration options to customize the shared page layout and content visibility.

Highlights

• Share Access for Protected Notes: Introduced cookie-based and query-based authorization for attachments and assets within notes protected by login:password, addressing the issue where browsers do not send Authorization headers for these resources.
• New Share Control Attributes: Added several new labels to provide fine-grained control over shared content: #shareExclude to completely exclude a note from sharing, #shareTemplateNoPrevNext to hide bottom navigation, #shareTemplateNoLeftPanel to hide the left panel, #shareContentAccess to manually configure content access authentication (cookie, query, or basic), and #shareAccessTokenTimeout to set token expiration.
• Content Access Token Management: Implemented a ContentAccessor class to manage tokens for content access, ensuring a single token can be used for multiple accesses and preventing user interference.
• Dynamic URL Rewriting: Modified the content renderer to dynamically append content access tokens to URLs for various assets (CSS, JS, images, PDFs, attachments) when query-based authentication is enabled.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a robust mechanism for handling access to protected attachments in shared notes, which was a significant limitation. The addition of cookie-based and query-param-based tokens is a good solution, and the new configuration labels provide great flexibility. The code is mostly well-structured, but I've identified a few areas that need improvement regarding type safety, code clarity, and potential security vulnerabilities. I've pointed out a critical type issue, a potential token leak, and several medium-severity issues related to maintainability and correctness.