Skip to content

Conversation

@joyent-automation
Copy link

OS-6458 elfedit failure with large stripped file

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/3035/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@rmustacc commented at 2017-12-05T21:27:50

Patch Set 1:

(1 comment)

Patch Set 1 code comments
usr/src/cmd/sgs/elfedit/common/elfedit_machelf.c#279 @rmustacc

Stylistically can you make all of these explicit comparisons. As in 'symtab != NULL'?

usr/src/cmd/sgs/elfedit/common/elfedit_machelf.c#279 @jperkin

Sure, have pushed an updated changeset.

@jperkin commented at 2017-12-06T12:58:03

Patch Set 1:

(1 comment)

@rmustacc commented at 2017-12-07T00:02:02

Patch Set 2: Code-Review+1

@jasonbking commented at 2017-12-08T00:54:03

Patch Set 2: Code-Review+1

@richlowe commented at 2019-02-08T22:52:14

Patch Set 2: Code-Review+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants