OS-8443 Update Bhyve SMBIOS Manufacturer #472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
NOTE: Changing things here may break cloud-init, especially older versions. |
bahamat
suggested changes
May 24, 2024
| */ | ||
| (void) snprintf(smbios, sizeof (smbios), | ||
| "1,manufacturer=Joyent,product=SmartDC HVM,version=7.%s," | ||
| "1,manufacturer=Triton Data Center,product=Triton HVM,version=7.%s," |
There was a problem hiding this comment.
The product at least needs to stay SmartDC HVM. Changing this will definitely break cloud-init that HVM images rely on. Even if we changed upstream cloud-init, all existing images wouldn't get that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing...