Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for OS-7666: vminfod times out while starting with thousands of snapshots #971

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

plitc
Copy link

@plitc plitc commented Feb 10, 2021

No description provided.

@twhiteman
Copy link
Contributor

Thanks - these changes look like they are worthwhile, but I must note that I don't think any of these changes would affect vminfod:

  • imgadm is not used by vminfod (as far as I could see)
  • VM.js changes affect vmadm - notably to the provision, reprovision and archiveZone methods
  • sysinfo changes would affect a non-global zone (i.e. when sysinfo is called from inside of a zone)
  • others are utility commands and/or used for tests

@plitc
Copy link
Author

plitc commented Feb 11, 2021

what about src/vm/node_modules/vmload/vmload-datasets.js ?

@twhiteman
Copy link
Contributor

what about src/vm/node_modules/vmload/vmload-datasets.js ?

Yes - all of the main code for vminfod will be inside these two directories:

  • src/vm/node_modules/vminfod/
  • src/vm/node_modules/vmload/ (shared vmadm and vminfod code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants