Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a bunch of stuff. #346

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update a bunch of stuff. #346

wants to merge 4 commits into from

Conversation

amouat
Copy link
Contributor

@amouat amouat commented Jul 5, 2023

No description provided.

Signed-off-by: Adrian Mouat <[email protected]>
Signed-off-by: Adrian Mouat <[email protected]>
Signed-off-by: Adrian Mouat <[email protected]>
@amouat
Copy link
Contributor Author

amouat commented Jul 29, 2023

@awoimbee I wanted to merge this before moving, but I no longer have the ability to force merges without review :)

@awoimbee
Copy link
Collaborator

awoimbee commented Aug 2, 2023

I think this PR should only update your email, not a fan of adding unused imports and //TODO: tests are interleaved to avoid some race condition that should be investigated while this race condition does not seem to happen in https://github.com/Extrality/trow

@amouat
Copy link
Contributor Author

amouat commented Aug 2, 2023

I was mainly trying to update a bunch of dependencies to resolve vulnerabilities. But then the tests didn't pass, so I needed to make some changes.

The alternative is to first merge the extrality fork, would you rather do it that way around?

@awoimbee
Copy link
Collaborator

Sorry, missed this one

The alternative is to first merge the extrality fork, would you rather do it that way around?

Absolutely, my fork has a lot of changes, rebasing would not be fun !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants