Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded configurations by play vars #13

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fwiesweg
Copy link

Hi,

I pulled some of the hard-coded constants into the playbook and command line arguments. If you feel like you'd like this upstream, let me know and I'll update the README. Fixes and improvements are of course welcome.

Best,
Florian

@fwiesweg
Copy link
Author

Oh and thanks for the good work! Really made our builds run quite a bit quicker.

@spanezz
Copy link
Contributor

spanezz commented Oct 31, 2022

Thanks, I like the direction this is going!

Unless I'm mistaken, nspawn-runner with this change would change behaviour on existing deployments. I wonder if the previous hardcoded values could be used as defaults when nspawn_runner_* keys are not present in the configuration, to allow smooth upgrades?

@kapouer, since you're also having nspawn-runner deployed, what do you think?

@kapouer
Copy link
Contributor

kapouer commented Oct 31, 2022

Indeed, keeping default behavior is good, unless there are better defaults which should be used.

@fwiesweg
Copy link
Author

fwiesweg commented Nov 2, 2022

There you go ;-) I have not gotten around to test the latest commit with the old defaults in our installation, but the changes are quite straightforward.

Some systems (e.g. Arch) do not necessarily have the systemd binary on
PATH, so instead rely on something which we need to call later anyway.
@fwiesweg
Copy link
Author

fwiesweg commented Nov 4, 2022

Just tested it on our ci infrastructure and of course found some ... not so intelligent bugs. I fixed them all and updated the branch. README has been updated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants