-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hardcoded configurations by play vars #13
base: main
Are you sure you want to change the base?
Conversation
Oh and thanks for the good work! Really made our builds run quite a bit quicker. |
Thanks, I like the direction this is going! Unless I'm mistaken, nspawn-runner with this change would change behaviour on existing deployments. I wonder if the previous hardcoded values could be used as defaults when @kapouer, since you're also having nspawn-runner deployed, what do you think? |
Indeed, keeping default behavior is good, unless there are better defaults which should be used. |
There you go ;-) I have not gotten around to test the latest commit with the old defaults in our installation, but the changes are quite straightforward. |
Some systems (e.g. Arch) do not necessarily have the systemd binary on PATH, so instead rely on something which we need to call later anyway.
Just tested it on our ci infrastructure and of course found some ... not so intelligent bugs. I fixed them all and updated the branch. README has been updated as well. |
Hi,
I pulled some of the hard-coded constants into the playbook and command line arguments. If you feel like you'd like this upstream, let me know and I'll update the README. Fixes and improvements are of course welcome.
Best,
Florian