Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing transfer to device in ProjectedGradientDescentPyTorch #2558

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

beat-buesser
Copy link
Collaborator

Description

This pull request fixes a missing transfer to device in ProjectedGradientDescentPyTorch.

@beat-buesser beat-buesser self-assigned this Jan 16, 2025
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Jan 16, 2025
@beat-buesser beat-buesser added this to the ART 1.19.1 milestone Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.41%. Comparing base (fd63952) to head (d794c1f).
Report is 2 commits behind head on dev_1.19.1.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           dev_1.19.1    #2558   +/-   ##
===========================================
  Coverage       85.41%   85.41%           
===========================================
  Files             334      334           
  Lines           31001    31001           
  Branches         5300     5300           
===========================================
+ Hits            26478    26481    +3     
+ Misses           3055     3053    -2     
+ Partials         1468     1467    -1     
Files with missing lines Coverage Δ
...ient_descent/projected_gradient_descent_pytorch.py 95.86% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@kieranfraser kieranfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested on a GPU enabled instance and have replicated the issue error and confirmed this PR fixes the issue.

@beat-buesser beat-buesser merged commit d3280eb into dev_1.19.1 Jan 20, 2025
61 checks passed
@beat-buesser beat-buesser deleted the development_issue_2553 branch January 20, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RuntimeError in ProjectedGradientDescentPyTorch due to Device Mismatch
2 participants