Ensured calculation of a negative repost count does not happen

[mike182uk]

ref https://linear.app/ghost/issue/PROD-2332

It was possible to get a negative repost count if the post repost count had already been updated via another process whilst the post was being updated

[coderabbitai]

Walkthrough

A new integration test was added to the test suite for the KnexPostRepository to validate that the repost_count field for internal posts does not become negative, even in the presence of inconsistent database states. Additionally, the repository implementation was updated to use the SQL GREATEST function when updating the repost_count, ensuring that it cannot drop below zero. No changes were made to the public API or exported entities; all modifications are internal to the repository logic and its tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

• The changes involve a focused update to a SQL expression and the addition of a single, self-contained integration test. The logic is straightforward, with no changes to public interfaces or complex refactoring.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48a1f1a and ebf3c09.

📒 Files selected for processing (2)

• src/post/post.repository.knex.integration.test.ts (1 hunks)
• src/post/post.repository.knex.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• src/post/post.repository.knex.ts
• src/post/post.repository.knex.integration.test.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build, Test and Push

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch PROD-2332-fix-negative-reply-count-error

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mike182uk]

Why use CAST? From the AI:

 In MySQL, the repost_count column is defined as BIGINT UNSIGNED. When MySQL performs arithmetic operations on unsigned integers, it tries to keep the result unsigned as well.

  Here's what happens:

  1. Without CAST:
    - repost_count is 1 (unsigned)
    - We try to calculate: 1 + (-2)
    - MySQL attempts to calculate this as unsigned arithmetic
    - Since unsigned integers can't be negative, MySQL throws an error: "BIGINT UNSIGNED value is out of range"
  2. With CAST AS SIGNED:
    - repost_count is cast to a signed integer first
    - The calculation becomes: 1 + (-2) = -1 (as a signed integer)
    - Then GREATEST(0, -1) evaluates to 0
    - The final result 0 is valid for an unsigned column

  The CAST is necessary because MySQL's type system is strict about unsigned arithmetic. It won't allow intermediate calculations that would result in negative values, even if the final
  result (after applying GREATEST) would be non-negative.

[mike182uk]

This is now out of date so closing