-
-
Notifications
You must be signed in to change notification settings - Fork 13
Added support for RedisKvStore for Fedify #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce Redis as an optional key-value store for the application, configurable via environment variables. The Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15–20 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fedify uses the KvStore a lot and often with an expiry. Currently the MySQL backed KVStore can get overwhelmed with a lot of inserts, which can cause connections to be dropped which affects uptime for the core application. Redis also supports TTL out of the box, so this eradicates the need for a cleanup job running on the key_value table.
Fedify uses the KvStore a lot and often with an expiry. Currently the MySQL backed KVStore can get overwhelmed with a lot of inserts, which can cause connections to be dropped which affects uptime for the core application. Redis also supports TTL out of the box, so this eradicates the need for a cleanup job running on the key_value table.