🐛 Fixed "Paste URL as link" embed card fallback #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part of ENG-594 - the button's onClick behaviour was directly calling the `handlePasteAsLink` function which results in the passed-in argument being a DOM event when the function expects a URL, updated to call the function with the URL as the argument - unskipped test for this feature to avoid future regressions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 176 176
Lines 16548 16548
Branches 1781 1781
=======================================
Hits 14987 14987
Misses 1552 1552
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of ENG-594
handlePasteAsLinkfunction which results in the passed-in argument being a DOM event when the function expects a URL, updated to call the function with the URL as the argument