Extracted Unsplash-Selector Component package #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue We currently have 3 versions of the Unsplash selector; The Admin-X version, written in Typescript + React; The Koenig version, written in Javascript + React; and the original Ember version. This creates a standalone Unsplash-Selector package, extracted from the Admin-X version. The plan is to only have 1 package to maintain and be able to reuse it elsewhere to avoid having to maintain separate versions of a library that does exactly the same thing everywhere.
ronaldlangeveld
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 176 176
Lines 16615 16615
Branches 1778 1778
=======================================
Hits 15040 15040
Misses 1566 1566
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
We currently have 3 versions of the Unsplash selector; The Admin-X version, written in Typescript + React; The Koenig version, written in Javascript + React; and the original Ember version.
This creates a standalone Unsplash-Selector package, extracted from the Admin-X version. The plan is to only have 1 package to maintain and be able to reuse it elsewhere to avoid having to maintain separate versions of a library that does exactly the same thing everywhere.
Once this has been published, we will easily be able to import and reuse it in other React Applications.