Added cropped image as minimal image in CTA Card

[ronaldlangeveld]

ref https://linear.app/ghost/issue/PLG-361/fix-image-distortion-quirk-in-outlook

• Update emailCTATemplate to handle cropped images (256x256) for the minimal layout in Call to Action (CTA) cards when rendering emails.
• Fixes a bug causing images to be distorted on certain browse, affecting mostly Windows clients - according to Litmus these clients were problematic:

1. Outlook Office 365 (Windows)
2. Outlook 2016 (Windows)
3. Outlook 2019 (Windows)
4. AOL Mail (Edge / Windows)
5. Yahoo Mail (Firefox)

• Add tests to verify cropped image behaviour in the minimal CTA layout for email targets.
• Renamed resizeImage to getImageDimensions across gallery, image, product, and CTA renderers for consistent dimension handling. This is to make it clearer that this function doesn't resize images, but rather just get dimensions and sizes it without breaking the aspect ratio.

[coderabbitai]

Walkthrough

This pull request introduces a standardization of image handling across various node renderer modules by replacing instances of resizeImage with getResizedImageDimensions. The emailCTATemplate function's signature has been updated to include an additional options parameter, facilitating enhanced control over image optimization. The logic for calculating image dimensions has been adjusted based on specified width constraints, particularly for images exceeding 560 pixels, and new conditional logic has been implemented for handling different dataset layouts. The test suite for the Call To Action node has been expanded to ensure correct behavior when processing transformed images, specifically for minimal and immersive layouts. The utility function has been renamed without changing its core logic for computing image dimensions.

Possibly related PRs

• Added initial HTML and Email rendering #1434: Modifications in this PR relate directly to the emailCTATemplate function, which is also part of the changes introducing the renderCallToActionNode function.
• Generalized visibility property logic and added to CallToActionNode #1431: This PR enhances the CallToActionNode, similar to the current changes, by adding new parameters and logic for managing visibility and image dimensions.
• Updated html markup for CTA card frontend rendering #1442: This PR also modifies the emailCTATemplate function, indicating a direct connection in functionality with the current changes related to image handling.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/kg-default-nodes/lib/nodes/call-to-action/calltoaction-renderer.js

Oops! Something went wrong! :(

ESLint: 8.57.0

Error: Failed to load parser '@babel/eslint-parser' declared in 'packages/kg-default-nodes/.eslintrc.js': Cannot find module '@babel/eslint-parser'
Require stack:

• /packages/kg-default-nodes/.eslintrc.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
  at Function.resolve (node:internal/modules/helpers:145:19)
  at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46)
  at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39)
  at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43)
  at _normalizeObjectConfigDataBody.next ()
  at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
  at _normalizeObjectConfigData.next ()
  at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28)
  at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 339d9e9 and 1e0b6a0.

📒 Files selected for processing (2)

• packages/kg-default-nodes/lib/nodes/call-to-action/calltoaction-renderer.js (3 hunks)
• packages/kg-default-nodes/test/nodes/call-to-action.test.js (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• packages/kg-default-nodes/lib/nodes/call-to-action/calltoaction-renderer.js
• packages/kg-default-nodes/test/nodes/call-to-action.test.js

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Node 22.13.1
• GitHub Check: Node 20.11.1

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (2a00f9e) to head (339d9e9).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
.../lib/nodes/call-to-action/calltoaction-renderer.js	86.66%	2 Missing ⚠️
...efault-nodes/lib/nodes/product/product-renderer.js	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
- Coverage   90.90%   90.86%   -0.04%     
==========================================
  Files         187      187              
  Lines       17381    17517     +136     
  Branches     1929     1953      +24     
==========================================
+ Hits        15800    15917     +117     
- Misses       1572     1591      +19     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.