🐛 Addressed the issue where files in the uploads folder couldn't be deleted in case of an error.#521
Closed
varadekd wants to merge 1 commit intoTryGhost:mainfrom
Closed
🐛 Addressed the issue where files in the uploads folder couldn't be deleted in case of an error.#521varadekd wants to merge 1 commit intoTryGhost:mainfrom
varadekd wants to merge 1 commit intoTryGhost:mainfrom
Conversation
…eleted in case of an error. Closes TryGhost#519 - In the scenario where a user uploaded corrupted files and attempted to scan them using gscan, an error occurred. - Previously, in this scenario, we failed to delete the uploaded file stored locally under the uploads folder. - Issue found: The identified bug was that we were only deleting the file when the promise was successfully resolved, and in the case of an error, we were simply moving to the next middleware. - Issue fixed: To resolve this issue, a finally block has been added to ensure that uploaded files are deleted in any case.
Member
|
Superseded by #686, which fixes the cleanup bug while ensuring next() is called exactly once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #519