Skip to content

Decrease log level of no schema for table because it's very common #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented May 19, 2025

The default of read_csv_folder is require_schema = false, and for most basic use cases, we won't have a schema.
So, making the @warn a @debug makes it less verbose.

Related issues

There is no related issue.

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.60%. Comparing base (96bb385) to head (de3a9e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   72.60%   72.60%           
=======================================
  Files           6        6           
  Lines         292      292           
=======================================
  Hits          212      212           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abelsiqueira abelsiqueira marked this pull request as ready for review May 19, 2025 10:25
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datejada datejada merged commit 8d0deb9 into main May 21, 2025
8 checks passed
@datejada datejada deleted the read-csv-less-verbose branch May 21, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants