Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailutils #1651

Closed
wants to merge 10 commits into from
Closed

mailutils #1651

wants to merge 10 commits into from

Conversation

unknown07724
Copy link

adds a new block, mail to (email)
it automatically adds mailto: to the email you provide

@unknown07724
Copy link
Author

ignore timeutils just copy mailutils

@CubesterYT
Copy link
Member

We require one extension per Pull Request, we simply cannot merge this PR by only merging one of the files. Merging PRs merges everything in the change list.

@CubesterYT
Copy link
Member

And I don't seem to find much use for this extension, considering it can be made workaroundable by using the networking extension.

@unknown07724
Copy link
Author

Well Idk how to make a pull with only 1 file

@RockyTheProtogen
Copy link

Well Idk how to make a pull with only 1 file

What IDE are you using?

@unknown07724
Copy link
Author

I used github to make the pull request

@RockyTheProtogen
Copy link

I used github to make the pull request

What did you use to make the commits?

@unknown07724
Copy link
Author

I told you already

@RockyTheProtogen
Copy link

RockyTheProtogen commented Sep 4, 2024 via email

@unknown07724
Copy link
Author

imma use issues from now on because I don't know how to do pull requests apparently

@RockyTheProtogen
Copy link

RockyTheProtogen commented Sep 5, 2024 via email

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
@Thebloxers998
Copy link

Your supposed use Scratch.redirect() instead of window.location.href =

@unknown07724
Copy link
Author

Your supposed use Scratch.redirect() instead of window.location.href =

for normal URLS, not for mailto:

@GarboMuffin
Copy link
Member

no it should probably be all of them

@unknown07724
Copy link
Author

no it should probably be all of them
scratch.redirect is only to be used on https:// urls

@Thebloxers998
Copy link

no it should probably be all of them

scratch.redirect is only to be used on https:// urls

How come you have so many bugs

@Thebloxers998
Copy link

Thebloxers998 commented Nov 22, 2024

All extension code must be within

  1. (function (Scratch)
  2. { })(Scratch);

@yuri-kiss
Copy link
Member

This is basically just if checks, a join block and the network extension.

@yuri-kiss yuri-kiss closed this Dec 25, 2024
@unknown07724

This comment was marked as abuse.

@Thebloxers998

This comment was marked as abuse.

@unknown07724

This comment was marked as off-topic.

@Thebloxers998

This comment was marked as off-topic.

@Thebloxers998

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants