Skip to content

Lily/Video: pause videos when project paused #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

fath11
Copy link
Contributor

@fath11 fath11 commented Jan 15, 2025

Resolved issue #1671

Videos will be paused when the project is paused.

Videos will be paused when the project is paused.
@github-actions github-actions bot added the pr: change existing extension Pull requests that change an existing extension label Jan 15, 2025
@GarboMuffin
Copy link
Member

!format

@GarboMuffin GarboMuffin linked an issue Jan 15, 2025 that may be closed by this pull request
@GarboMuffin GarboMuffin changed the title Update Lily/Video.js Lily/Video: pause videos when project paused Jan 15, 2025
@fath11
Copy link
Contributor Author

fath11 commented Jan 15, 2025

i will remember to not commit big generated translations next time

@yuri-kiss
Copy link
Member

Just gotta wait for the events to be on the site publicly

@GarboMuffin
Copy link
Member

they are

@GarboMuffin GarboMuffin merged commit 877fc29 into TurboWarp:master Jan 15, 2025
3 checks passed
@yuri-kiss
Copy link
Member

they are

my bad 🤣 i thought it had to go through staging which i thought would have been slower

@GarboMuffin
Copy link
Member

even if the event isnt there, this fails gracefully without regressions so we wouldn't have to wait

it was rushed in with today's deploy because i forgot to deploy last week

@fath11 fath11 deleted the Auto-pause-for-Lily/Video branch January 25, 2025 06:38
jexjws pushed a commit to 40codeTeam/tw-extensions that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lily/Video: pause video playback when pausing the project
4 participants