Skip to content

utilities: Port "normalize" block from Lily's Toolbox #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

NexusKitten
Copy link
Contributor

@NexusKitten NexusKitten commented Feb 26, 2025

Technically isn't a 1:1 port (I cleaned up the code a little and added an extra Scratch.Cast call just to be safe), however it functions practically identically.

chrome_6eUcMHXnQ9

@github-actions github-actions bot added the pr: change existing extension Pull requests that change an existing extension label Feb 26, 2025
@NexusKitten
Copy link
Contributor Author

!format

@yuri-kiss
Copy link
Member

"it's arguable that this would be better fit for the math extension, but i feel like it's general use enough to fit into utilities :idrk:" -Nameless on discord

@CubesterYT
Copy link
Member

I think it's suited for Math better, considering the Math extension has some of the same blocks utilities has. So we can just have it more centralized over expanding a general extension.

@GarboMuffin
Copy link
Member

This is not a normalize block it is a sign function block. Available in browsers as Math.sign

One of the math extensions makes more sense

@NexusKitten
Copy link
Contributor Author

superseded by #1981

CubesterYT pushed a commit that referenced this pull request Feb 27, 2025
continuation of #1980,
everything from there applies except:

- ctrl + f replace every time I said "normalize" with "sign of"
- block code was changed a bit because apparently there's a math
function to get sign (how am i just now learning of this)


![chrome_uiOoLW48ex](https://github.com/user-attachments/assets/b880379d-8a5d-4848-b84f-69948ee2500a)

---------

Co-authored-by: DangoCat[bot] <[email protected]>
jexjws pushed a commit to 40codeTeam/tw-extensions that referenced this pull request Mar 17, 2025
continuation of TurboWarp#1980,
everything from there applies except:

- ctrl + f replace every time I said "normalize" with "sign of"
- block code was changed a bit because apparently there's a math
function to get sign (how am i just now learning of this)


![chrome_uiOoLW48ex](https://github.com/user-attachments/assets/b880379d-8a5d-4848-b84f-69948ee2500a)

---------

Co-authored-by: DangoCat[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants