Skip to content

Update Text extension for casting compliance under new guidelines #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

PPPDUD
Copy link
Contributor

@PPPDUD PPPDUD commented Mar 1, 2025

I fixed the Text extension to use the Scratch.Cast.* API, as specified in #1810.
This is similar to part of the pull request #1990, where the same idea was proposed.

I may have made some mistakes during my review of precedent regarding this matter, so please alert me if I got something incorrect.

@github-actions github-actions bot added the pr: change existing extension Pull requests that change an existing extension label Mar 1, 2025
@WAYLIVES
Copy link

WAYLIVES commented Mar 1, 2025

!format

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Mar 1, 2025

!format

What??

@CST1229
Copy link
Collaborator

CST1229 commented Mar 1, 2025

!format

What??

it's a bot in this repo to do proper formatting
image

Copy link

github-actions bot commented Mar 1, 2025

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Mar 1, 2025

!format

What??

it's a bot in this repo to do proper formatting image

Thanks for explaining.

Copy link

github-actions bot commented Mar 1, 2025

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

@WAYLIVES
Copy link

WAYLIVES commented Mar 1, 2025

!format

What??

it's a bot in this repo to do proper formatting image

Thanks for explaining.

:trollface:

Copy link
Contributor Author

@PPPDUD PPPDUD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good and passes my testing standards. GitHub won't let me approve them because I made the pull request.
Does anyone over here have the privileges to accept PR changes from others?

@SharkPool-SP
Copy link
Collaborator

This seems good and passes my testing standards. GitHub won't let me approve them because I made the pull request.

Does anyone over here have the privileges to accept PR changes from others?

I do, but you didn't resolve the issues

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Mar 3, 2025

This seems good and passes my testing standards. GitHub won't let me approve them because I made the pull request.
Does anyone over here have the privileges to accept PR changes from others?

I do, but you didn't resolve the issues

I'm confused. GitHub doesn't just let me accept the changes somehow?

@SharkPool-SP
Copy link
Collaborator

This seems good and passes my testing standards. GitHub won't let me approve them because I made the pull request.

Does anyone over here have the privileges to accept PR changes from others?

I do, but you didn't resolve the issues

I'm confused. GitHub doesn't just let me accept the changes somehow?

They're not changes, those are just comments telling you what do change

@SharkPool-SP
Copy link
Collaborator

please fix the issues otherwise this will go stale

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Mar 10, 2025

please fix the issues otherwise this will go stale

Is there a way I can transfer the responsibilities to you? I am recovering from illness right now and would prefer not to be wrangling GitHub's UI.

@SharkPool-SP
Copy link
Collaborator

done

@SharkPool-SP
Copy link
Collaborator

!format

@PPPDUD
Copy link
Contributor Author

PPPDUD commented Mar 10, 2025

done

Thanks!

@SharkPool-SP SharkPool-SP merged commit 54c1e8e into TurboWarp:master Mar 12, 2025
3 checks passed
@PPPDUD PPPDUD deleted the patch-4 branch June 29, 2025 21:22
@PPPDUD
Copy link
Contributor Author

PPPDUD commented Jun 29, 2025

@SharkPool-SP Sorry for placing those responsibilities on you. Thanks once again for cleaning up my code for me though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants