-
-
Notifications
You must be signed in to change notification settings - Fork 280
Update Text extension for casting compliance under new guidelines #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
!format |
What?? |
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good and passes my testing standards. GitHub won't let me approve them because I made the pull request.
Does anyone over here have the privileges to accept PR changes from others?
I do, but you didn't resolve the issues |
I'm confused. GitHub doesn't just let me accept the changes somehow? |
They're not changes, those are just comments telling you what do change |
please fix the issues otherwise this will go stale |
Is there a way I can transfer the responsibilities to you? I am recovering from illness right now and would prefer not to be wrangling GitHub's UI. |
done |
!format |
Thanks! |
@SharkPool-SP Sorry for placing those responsibilities on you. Thanks once again for cleaning up my code for me though! |
I fixed the Text extension to use the Scratch.Cast.* API, as specified in #1810.
This is similar to part of the pull request #1990, where the same idea was proposed.
I may have made some mistakes during my review of precedent regarding this matter, so please alert me if I got something incorrect.