Lily/Skins: Fix some fatal loading bugs. #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-kiss
added
bug
|
!format |
GarboMuffin
added a commit
to TurboWarp/desktop
that referenced
this pull request
May 30, 2025
avoid surprises from TurboWarp/extensions#2128 TurboWarp/extensions#2137 the old one is also buggy, but in known ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a lot of errors if it happens repeatedly and can lead to project corruption if handled incorrectly.
This fixes some of thoes loading bugs. fixes: #2127
The issue arises from the fact that you can rename / delete / cancel the loading of a costume / skin while its still loading, and the renderer throws and error if that happens at a bad time, Skins doesnt handle this, this aims to fix that issue