Skip to content

Xeltalliv/clippingblending: Fix canvas alpha compatibility and other changes #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 8, 2025

Conversation

Xeltalliv
Copy link
Contributor

@Xeltalliv Xeltalliv commented Jun 4, 2025

This:

  • Fixes compatibility with canvas having alpha, without changing behavior of any old projects compared to how they used to work (at least in theory).
  • Sorts out long standing issue of some blending modes working incorrectly, by deprecating old block and making a new one, where everything is done in a corrected and clean way.
  • Adds new blending modes, to provide proper solutions to what was done through bugs.
  • Adds API, so that Shaded extension can be compatible with this extension, without the need for maintaining a custom fork of it.
  • Adds a label explaining why there is sometimes no blocks in the palette.
    image

@github-actions github-actions bot added the pr: change existing extension Pull requests that change an existing extension label Jun 4, 2025
@yuri-kiss yuri-kiss added the javascript Pull requests that update javascript code label Jun 4, 2025
@yuri-kiss yuri-kiss requested a review from GarboMuffin June 4, 2025 03:57
@SharkPool-SP
Copy link
Collaborator

Instead of the function for getting the drawable you could just use the Drawable class in renderer.exports

@Xeltalliv
Copy link
Contributor Author

Um, that's exactly what I did

image

let Drawable = renderer?.exports?.Drawable || getDrawable();

but I kept the old one as a fallback, in case this extension was used in some obscure outdated turbowarp mods without renderer.exports.

@SharkPool-SP
Copy link
Collaborator

oh didnt even see that mb, was looking over it on my phone lol

@SharkPool-SP
Copy link
Collaborator

Yuri has to approve because she made requests. I can’t merge :(

@SharkPool-SP SharkPool-SP requested a review from yuri-kiss June 8, 2025 00:19
@GarboMuffin GarboMuffin dismissed yuri-kiss’s stale review June 8, 2025 00:22

resolved probably

@GarboMuffin GarboMuffin merged commit ec4d5a5 into TurboWarp:master Jun 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update javascript code pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants