-
-
Notifications
You must be signed in to change notification settings - Fork 280
Xeltalliv/clippingblending: Fix canvas alpha compatibility and other changes #2142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the function for getting the drawable you could just use the Drawable class in renderer.exports |
Um, that's exactly what I did
but I kept the old one as a fallback, in case this extension was used in some obscure outdated turbowarp mods without renderer.exports. |
oh didnt even see that mb, was looking over it on my phone lol |
yuri-kiss
previously requested changes
Jun 5, 2025
GarboMuffin
approved these changes
Jun 7, 2025
SharkPool-SP
approved these changes
Jun 8, 2025
Yuri has to approve because she made requests. I can’t merge :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update javascript code
pr: change existing extension
Pull requests that change an existing extension
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This: