Make field cursors reflect the entire click target area instead of just the field group#23
Merged
GarboMuffin merged 1 commit intoTurboWarp:developfrom May 14, 2025
Conversation
…st the field itself
Member
|
You're welcome, people of TurboWarp. Many lives will be saved.
|
Member
|
thanks |
CubesterYT
referenced
this pull request
in Nitro-Bolt/scratch-blocks
Feb 23, 2026
* increase field cursor area to the entire click target * Turning blocks now use the angle field (scratch-blocks) * Add setting color in procedure playground (#8) Add setting color in procedure playground * nitpick fix, jwk was correct in the naming * Add a way to reload core files * add require * woosh * Fix some stuff and update isValidHexCode_ * Fix that 1 annoying error and update some stuff to use goog.queueMicrotask * Don't use this * aaaa * Update core/polypatch.js Co-authored-by: Cubester <[email protected]> * Update polypatch.jsGWAHHHHHHHHHHHHHHHHHHHH * Checking the Box (#11) Adds checkboxes to NitroBolt, and makes it built into all boolean inputs. --------- Co-authored-by: jwklong <[email protected]> Co-authored-by: Cubester <[email protected]> Co-authored-by: CST1229 <[email protected]> * Back to normal * Make field cursors reflect the entire click target area instead of just the field itself (#23) * Update GitHub Actions workflows - update actions/setup-node to fix extra 10 minute delay in CI - update Node.js - use version ranges instead of commit hashes to get future updates automatically (we already trust the GitHub Actions team) * Adjust angle dropdown color to match parent block (#24) Co-authored-by: Thomas Weber <[email protected]> * fix checkboxes * dont include my editor stuff pretty please * refactor checkbox clicking to use the gesture system this fixes a bug where if you drag the mouse cursor while clicking on an unchecked boolean input, but not enough to drag the block, it clicks the block below instead of checking the checkbox * only run connectBoolean on boolean inputs even if an input is clickable * fix undo/redo with checkboxes * fix workflow * im cooking * get rid of mysterious file * tada * jolly good doings * revert * Revert "revert" This reverts commit d223b29. * fix checkboxes (blocks part) not custom block ghost blocks though * Fix displaying -0 in visual reports (#25) * collapsible blocks * Revert "Fix displaying -0 in visual reports (#25)" This reverts commit 3539a61. It gets stringified in VM so we'll fix it in there instead. * add sensing_online * entries of {} block * Disable collapsing for procedure definition block * New JSON blocks: get object properties, array length, slice array, reverse array * fix: use extension instead of output --------- Co-authored-by: CST1229 <[email protected]> Co-authored-by: jwklong <[email protected]> Co-authored-by: yuri-kiss <[email protected]> Co-authored-by: jwklong <[email protected]> Co-authored-by: Thomas Weber <[email protected]> Co-authored-by: SharkPool <[email protected]> Co-authored-by: Thomas Weber <[email protected]> Co-authored-by: ddededodediamante <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Not really a bug, more of a teensy tiny quality of life improvement proposal. Basically it just applies
this.CURSORset on fields to apply to the entire click target instead of just the field group.Before:
After:
Reason for Changes
This makes the field's cursor reflect the actual area where it's clickable; so if your cursor turns into a text cursor you now know that you're hovering over the text field and will focus it if you click.
Test Coverage
Not really tested (aside from trying it out in the playground).
This pull request was made on behalf of the entire NitroBolt project. /j (more specifically, Cubester requested me to upstream this one change)