Skip to content

Allow refreshBlocks() to specify extension #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Allow refreshBlocks() to specify extension #228

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a56912
Allow `refreshBlocks()` to specify extension
FurryR Oct 6, 2024
f81e165
Merge branch 'TurboWarp:develop' into develop
FurryR Dec 25, 2024
0b9c4bd
explicit error
GarboMuffin Dec 26, 2024
45b7b5f
return promise not throw
GarboMuffin Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions src/extension-support/extension-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,19 +277,25 @@ class ExtensionManager {

/**
* Regenerate blockinfo for any loaded extensions
* @param {string} [optExtensionId] Optional extension ID for refreshing
* @returns {Promise} resolved once all the extensions have been reinitialized
*/
refreshBlocks () {
const allPromises = Array.from(this._loadedExtensions.values()).map(serviceName =>
dispatch.call(serviceName, 'getInfo')
.then(info => {
info = this._prepareExtensionInfo(serviceName, info);
dispatch.call('runtime', '_refreshExtensionPrimitives', info);
})
.catch(e => {
log.error('Failed to refresh built-in extension primitives', e);
})
);
refreshBlocks (optExtensionId) {
const refresh = serviceName => dispatch.call(serviceName, 'getInfo')
.then(info => {
info = this._prepareExtensionInfo(serviceName, info);
dispatch.call('runtime', '_refreshExtensionPrimitives', info);
})
.catch(e => {
log.error('Failed to refresh built-in extension primitives', e);
});
if (optExtensionId) {
if (!this._loadedExtensions.has(optExtensionId)) {
return Promise.reject(new Error(`Unknown extension: ${optExtensionId}`));
}
return refresh(this._loadedExtensions.get(optExtensionId));
}
const allPromises = Array.from(this._loadedExtensions.values()).map(refresh);
return Promise.all(allPromises);
}

Expand Down
Loading