Merged
Conversation
This was referenced Jul 29, 2025
Closed
smallsaucepan
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
marchingsquareshas a somewhat conflicted licensing story, I went ahead and reimplemented it from scratch to clear up any ambiguity.Performance is slower than isolines, but overall we're quite a bit faster than the original implementation (2-3x again).
The matrix2 issues are fixed in another PR.
Fixes #1084, #2509
Pretty sure this fixed #2509 as well. Here's a picture of the output I got, but since the test file is quite large I omitted adding it to permanent test cases since it isn't really clear what caused the issue in the first place.