Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Julia compat entry to 1.10 #342

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Bump Julia compat entry to 1.10 #342

merged 4 commits into from
Nov 6, 2024

Conversation

penelopeysm
Copy link
Member

Mooncake, and Enzyme 0.13, and Turing, only support Julia 1.10+ so I figure we may as well drop support for anything before it.

I tidied up the GHA workflows a bit too.

@torfjelde
Copy link
Member

Happy with this! But can you bump the minor version since this will be breaking?

@yebai yebai merged commit cd3cce8 into mhauru/enzyme-v0.13 Nov 6, 2024
3 of 7 checks passed
@yebai yebai deleted the py/julia-1.10 branch November 6, 2024 11:17
@penelopeysm
Copy link
Member Author

@torfjelde I'm sorry I missed this!

Do you explain how bumping Julia compatibility is breaking? The way I see it, for anybody on >=1.10, nothing changed. For anybody on <1.10, the new version effectively doesn't exist, so there is no breakage.

@torfjelde
Copy link
Member

That's a fair argument 👍 I think it's a bit of a gray area: I agree that it won't actually break anyone's code, however it arguably marks a point where we stop supporting pre-1.10 versions. I think one good argument for doing it is that it'll be easier to do backports of bugfixes if we end up feeling the need for that: we can just release new versions on the previous minor version.

Sensible or nah?

@penelopeysm
Copy link
Member Author

True that's a good argument:) Semver also doesn't mandate that a non-breaking release has to be a patch, so I'm also quite happy to just consider bumping Julia compat to be a minor release based on convention. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants