Draft
Conversation
Contributor
|
Bijectors.jl documentation for PR #395 is available at: |
devmotion
reviewed
Jun 19, 2025
Co-authored-by: David Widmann <[email protected]>
AoifeHughes
reviewed
Jul 7, 2025
| lower_triangular(A::AbstractMatrix) = convert(typeof(A), LowerTriangular(A)) | ||
| upper_triangular(A::AbstractMatrix) = convert(typeof(A), UpperTriangular(A)) | ||
|
|
||
| # TODO: Replace remaining uses of `pd_from_{lower,upper}` with |
Contributor
There was a problem hiding this comment.
Is this a big task / will it be part of this PR?
Member
Author
There was a problem hiding this comment.
I think so. That's partly why I kept this PR marked as a draft and didn't request reviews. (The other reason is the failing tests)
This was referenced Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #387. Turns out that a different matrix type that allows for numerically stable determinants already exists, and it's
PDMats.PDMat. Credit to @mhauru for the suggestion.