Refactor: refactored authenticate field to infer from username and pa…

…ssword insted of specifying it inside config.

README.md

@@ -2046,7 +2046,6 @@ endpoints:
     ssh:
       username: "username"
       password: "password"
-      authenticate: true
     body: |
       {
         "command": "uptime"
@@ -2057,7 +2056,22 @@ endpoints:
       - "[STATUS] == 0"
 ```
 
-you can also use no authentication to monitor the endpoint by setting the `authenticate` field to `false`, but will it only check for connection status.
+you can also use no authentication to monitor the endpoint by not specifying the username
+and password fields.
+
+```yaml
+endpoints:
+  - name: ssh-example
+    url: "ssh://example.com:22" # port is optional. Default is 22.
+    ssh:
+      username: ""
+      password: ""
+
+    interval: 1m
+    conditions:
+      - "[CONNECTED] == true"
+      - "[STATUS] == 0"
+```
 
 The following placeholders are supported for endpoints of type SSH:
 - `[CONNECTED]` resolves to `true` if the SSH connection was successful, `false` otherwise

config/endpoint/endpoint.go

@@ -363,7 +363,7 @@ func (e *Endpoint) call(result *Result) {
 		}
 		result.Duration = time.Since(startTime)
 	} else if endpointType == TypeSSH {
-		if !e.SSHConfig.Authenticate {
+		if len(e.SSHConfig.Username) == 0 && len(e.SSHConfig.Password) == 0 {
 			result.Connected, result.HTTPStatus, err =
 				client.CheckSSHBanner(strings.TrimPrefix(e.URL, "ssh://"), e.ClientConfig)
 

config/endpoint/endpoint_test.go

@@ -527,9 +527,8 @@ func TestEndpoint_ValidateAndSetDefaultsWithSSH(t *testing.T) {
 				Name: "ssh-test",
 				URL:  "https://example.com",
 				SSHConfig: &ssh.Config{
-					Username:     scenario.username,
-					Password:     scenario.password,
-					Authenticate: true,
+					Username: scenario.username,
+					Password: scenario.password,
 				},
 				Conditions: []Condition{Condition("[STATUS] == 0")},
 			}

config/endpoint/ssh/ssh.go

@@ -20,9 +20,10 @@ type Config struct {
 
 // Validate the SSH configuration
 func (cfg *Config) Validate() error {
-	if cfg.Authenticate == false {
+	if len(cfg.Username) == 0 && len(cfg.Password) == 0 {
 		return nil
 	}
+
 	if len(cfg.Username) == 0 {
 		return ErrEndpointWithoutSSHUsername
 	}

config/endpoint/ssh/ssh_test.go

@@ -6,12 +6,11 @@ import (
 )
 
 func TestSSH_validate(t *testing.T) {
-	cfg := &Config{Authenticate: true}
-	if err := cfg.Validate(); err == nil {
-		t.Error("expected an error")
-	} else if !errors.Is(err, ErrEndpointWithoutSSHUsername) {
-		t.Errorf("expected error to be '%v', got '%v'", ErrEndpointWithoutSSHUsername, err)
+	cfg := &Config{}
+	if err := cfg.Validate(); err != nil {
+		t.Error("didn't expect an error")
 	}
+
 	cfg.Username = "username"
 	if err := cfg.Validate(); err == nil {
 		t.Error("expected an error")