-
-
Notifications
You must be signed in to change notification settings - Fork 629
feat(endpoints): add domain-expiration-only-check #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2abf238 to
9694008
Compare
|
@TwiN Is there anything I can do to help merge PR? Is there no progress? |
test result cpu: AMD Ryzen 7 4800H with Radeon Graphics BenchmarkEndpoint_Type-16 Cut + switch 5053628 238.7 ns/op 0 B/op 0 allocs/op Cut + map 2714998 438.6 ns/op 0 B/op 0 allocs/op switch HasPerfix 2683519 430.9 ns/op 0 B/op 0 allocs/op
9694008 to
8a079be
Compare
|
@PythonGermany Your PR qianlongzt#1 looks good to me, but what should I do next? |
|
@qianlongzt Just merge my changes into your branch. |
Refactor endpoint call method
| // domain expiration checked before call `call` | ||
| return | ||
| case TypeHTTP: | ||
| request = e.buildHTTPRequest() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed my previous refactoring introduces one unintended (and maybe unwanted change). The startTime is now set before starting to build the http request.
To restore the original behavior we should update the startTime after building the request:
| request = e.buildHTTPRequest() | |
| request = e.buildHTTPRequest() | |
| startTime = time.Now() |
Summary
test result for perfomance
cpu: AMD Ryzen 7 4800H with Radeon Graphics
BenchmarkEndpoint_Type-16
Cut + switch 5053628 238.7 ns/op 0 B/op 0 allocs/op
Cut + map 2714998 438.6 ns/op 0 B/op 0 allocs/op
switch HasPerfix 2683519 430.9 ns/op 0 B/op 0 allocs/op
Checklist
README.md, if applicable.