-
-
Notifications
You must be signed in to change notification settings - Fork 629
feat(endpoints): add domain-expiration-only-check #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qianlongzt
wants to merge
9
commits into
TwiN:master
Choose a base branch
from
qianlongzt:feat-endpoint-domain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+202
−128
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e531465
feat(endpoints): add domain-expiration-only-check
qianlongzt 8a079be
chore(endpoint): Refactor Type for simplification and better performance
qianlongzt dfbfab9
test(endpoint): add missing endpoint type test for grpc
qianlongzt 794c2da
refactor: Use switch for endpoint type
PythonGermany 5f84fab
refactor: Use maps copy
PythonGermany 0f38dc9
refactor: Use fmt appendf
PythonGermany c4c8205
refactor: Combine endpoint type switches
PythonGermany 48f4339
test(endpoint): move `BenchmarkEndpoint_Type` to file `endpoint_bench…
qianlongzt bd6db8b
Merge pull request #1 from PythonGermany/refactor-endpoint-call-method
qianlongzt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package endpoint | ||
|
|
||
| import ( | ||
| "testing" | ||
| ) | ||
|
|
||
| func BenchmarkEndpoint_Type(b *testing.B) { | ||
| for b.Loop() { | ||
| for _, tt := range testEndpoint_typeData { | ||
| endpoint := Endpoint{ | ||
| URL: tt.args.URL, | ||
| DNSConfig: tt.args.DNS, | ||
| } | ||
| if got := endpoint.Type(); got != tt.want { | ||
| b.Errorf("Endpoint.Type() = %v, want %v", got, tt.want) | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed my previous refactoring introduces one unintended (and maybe unwanted change). The startTime is now set before starting to build the http request.
To restore the original behavior we should update the startTime after building the request: