fix(endpoint): use custom resolver if specified for [IP] tests #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishanjain28
force-pushed
the
use_custom_resolver
branch
from
5ced376 to
5087627
Compare
TwiN
reviewed
May 24, 2025
TwiN
reviewed
May 24, 2025
|
@TwiN I addressed the PR feedback and it is ready for review again. |
ishanjain28
force-pushed
the
use_custom_resolver
branch
from
6322fa3 to
8cb38bc
Compare
|
Hi @TwiN, This PR is ready to be reviewed. Please let me know if you have any queries |
ishanjain28
force-pushed
the
use_custom_resolver
branch
from
8cb38bc to
5ef836e
Compare
TwiN
requested changes
Sep 16, 2025
Comment on lines
+63
to
+65
| // DNSResolverConfig is parsed DNSResolver | ||
| // We do this to avoid parsing DNSResolver every time it is needed | ||
| DNSResolverConfig *DNSResolverConfig `yaml:"-"` |
There was a problem hiding this comment.
Since this isn't a configuration, it shouldn't be exported and thus it should be dnsResolver.
Also, move it next to httpClient (if you have the time, please move both (httpClient and dnsResolver at the bottom of the struct)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #904
It updates the endpoint code to resolve a domain with the specified custom resolver if specified or go to the default resolver as fallback
No documentation changes are required since this fixes a bug
Checklist
README.md, if applicable.