Skip to content

Conversation

@mloskot
Copy link
Contributor

@mloskot mloskot commented May 11, 2025

Adds new node favicon to ui configuration with properties that allow to overwrite the three favicons which are currently in use in the index.html template.

Configuration Example

ui:
  favicon:
    # these are all optional, can be mixed and matched
    default: https://example.com/favicon.ico       # replaces default /favicon.ico
    size16x16: https://example.com/favicon.ico     # replaces default /favicon-16x16.png
    size32x32: https://example.com/logo-32x32.ico  # replaces default /favicon-32x32.png

References

@github-actions github-actions bot added the feature New feature or request label May 11, 2025
@mloskot mloskot mentioned this pull request May 11, 2025
@owennewo-dev
Copy link

Any reason why this has not been merged? I would appreciate if I could easily change the favicon.

@benedikt-bartscher
Copy link

This looks good to me, thanks @mloskot

i hope we can get a review from @TwiN and get it merged soon

@DavidSonoda
Copy link

Any updates on this? Thanks.

@TwiN
Copy link
Owner

TwiN commented Oct 30, 2025

@mloskot Could you add a quick test for the new feature?

@mloskot
Copy link
Contributor Author

mloskot commented Oct 30, 2025

@mloskot Could you add a quick test for the new feature?

Sure, I can try. I see there is also a conflict to resolve. Please, give me 2-3 days and I will deliver an update to this PR.

@TwiN
Copy link
Owner

TwiN commented Oct 30, 2025

@mloskot No problem, take your time!

Adds new node `favicon` to `ui` configuration
with properties that allow to overwrite the three
favicons which are currently in use in the index.html template.

Closes TwiN#174

Signed-off-by: Mateusz Łoskot <[email protected]>
@mloskot mloskot force-pushed the ml/feat/ui-favicon.ico branch from 42a3ad7 to cc5e2f2 Compare October 30, 2025 20:33
@mloskot
Copy link
Contributor Author

mloskot commented Oct 30, 2025

@TwiN I've resolved the conflicts and force-pushed to update this PR. I see there is a change to ui_test.go. Is there anything else to cover with tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support favicon

5 participants