feat(ui): Make tooltips toggleable #1236
Conversation
feat(dev): put back package.lock
|
I guess just let me know if you're interested in this @TwiN and I can resolve the merge conflicts. |
|
Gatus' old, old UI used to have this a long time ago, but it caused issues when you clicked on one, then navigated to another page without closing it first. Can you check that this isn't an issue? Otherwise, sounds like a good idea. |
I tested this, and it doesn't seem to cause issues when switching between pages. Even when jumping and clicking all over the place 😂 |
|
Fixed :)
|
|
@perfectra1n Could you fix the merge conflicts when you have a moment? |
|
Should be good to go now @TwiN :) |
|
@perfectra1n Quick question for you, if the user doesn't click a status (just hovers it), does it go away if cursor hovers elsewhere? In other words, is the tooltip persistent only when the user clicks a status? I'll test it on my end when I have a minute, but just want to confirm. |
|
That is correct: |
TwiN
changed the title
|
@perfectra1n Thank you for your contribution! |
|
@perfectra1n If you have some time, when you click multiple results from different EndpointCard, it looks like it leaves the result color from the other EndpointCards as if they're still selected: Not sure if you have time to look into this or not - I'll look when I have some time if you don't |
|
@perfectra1n Nevermind, I fixed it in 91931e4 |
|
Ahhhh interesting, good catch. Thanks for doing that! |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.26.0` -> `v5.27.0` | --- ### Release Notes <details> <summary>TwiN/gatus (ghcr.io/twin/gatus)</summary> ### [`v5.27.0`](https://github.com/TwiN/gatus/releases/tag/v5.27.0) [Compare Source](TwiN/gatus@v5.26.0...v5.27.0) #### What's Changed - feat(alerting): Add message-content parameter for Discord pings by [@​aaldebs99](https://github.com/aaldebs99) in [#​1335](TwiN/gatus#1335) - feat(ui): Make tooltips toggleable by [@​perfectra1n](https://github.com/perfectra1n) in [#​1236](TwiN/gatus#1236) - fix(alerting): remove discontinued jetbrains space alerting provider by [@​michael-baraboo](https://github.com/michael-baraboo) in [#​1329](TwiN/gatus#1329) - fix(ui): Handle refresh properly on SuiteDetails.vue by [@​TwiN](https://github.com/TwiN) in [#​1324](TwiN/gatus#1324) - fix(key): Support `(`, `)`, `+` and `&` as name/group by [@​TwiN](https://github.com/TwiN) in [#​1340](TwiN/gatus#1340) #### New Contributors - [@​aaldebs99](https://github.com/aaldebs99) made their first contribution in [#​1335](TwiN/gatus#1335) **Full Changelog**: <TwiN/gatus@v5.26.0...v5.27.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzUuNCIsInVwZGF0ZWRJblZlciI6IjQxLjEzNS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbWFnZSJdfQ==--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1792 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
|
@TwiN I think this has some problem still: I couldn't create a screenshot because then it was rendered fine... |
4 participants
Summary
Make the data points clicky, so they stay open and you can select the text!
Of course it goes away if you click outside of the box as well.
Checklist
README.md, if applicable.