Skip to content

fix(key): Support (, ), + and & as name/group #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

fix(key): Support (, ), + and & as name/group #1340

merged 1 commit into from
Oct 16, 2025
+28 −9

Conversation

TwiN
Copy link
Owner

@TwiN TwiN commented Oct 16, 2025

Summary

Adds support for (, ), + and & as name/group

Relevant: #1339

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@TwiN TwiN added bug Something isn't working area/ui Related to the user interface area/api Related to the REST API labels Oct 16, 2025
@TwiN TwiN merged commit ebd4068 into master Oct 16, 2025
3 checks passed
@TwiN TwiN deleted the fix/key branch October 16, 2025 20:47
@amai2012
Copy link

@TwiN That indeed fixed #1339 - thank you.

Side-effect: the history for endpoints with affected names has been reset.

@TwiN
Copy link
Owner Author

TwiN commented Oct 17, 2025

The side effect is acceptable, thank you for confirming.

@markormesher
Copy link

Out of interest this broke some working checks that contained parentheses but no plus sign. I have checks called foo bar (host name) which had the history dropped and external URLs that no longer work, causing some alerts. Easily fixed, just needed to replace the parens with dashes, and the history is no great loss - mostly just posing this in case anyone else comes across the same issue!

@TwiN
Copy link
Owner Author

TwiN commented Oct 19, 2025

@markormesher Hm, did the detail page with parentheses previously work?

That's a bit of an oversight on my part, my bad

@markormesher
Copy link

Yep, the dashboard view and detail views both worked fine with parens in the names. I just rolled back to 5.26.0 to confirm, and other than dropping the history each time I rolled back/forwards everything worked the same. I don't have any checks with + in the name so I didn't test that, but I'd guess it's because () are handled normally in URLs but + is interpreted differently.

Without external checks with heartbeat intervals I probably wouldn't have even noticed, I only saw it because their URL format changed which caused their heartbeats to start expiring.

alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Oct 20, 2025
@alexlebens
Update ghcr.io/twin/gatus Docker tag to v5.27.0 (#1792)
1127511 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.26.0` -> `v5.27.0` |

---

### Release Notes

<details>
<summary>TwiN/gatus (ghcr.io/twin/gatus)</summary>

### [`v5.27.0`](https://github.com/TwiN/gatus/releases/tag/v5.27.0)

[Compare Source](TwiN/gatus@v5.26.0...v5.27.0)

#### What's Changed

- feat(alerting): Add message-content parameter for Discord pings by [@&#8203;aaldebs99](https://github.com/aaldebs99) in [#&#8203;1335](TwiN/gatus#1335)
- feat(ui): Make tooltips toggleable by [@&#8203;perfectra1n](https://github.com/perfectra1n) in [#&#8203;1236](TwiN/gatus#1236)
- fix(alerting): remove discontinued jetbrains space alerting provider by [@&#8203;michael-baraboo](https://github.com/michael-baraboo) in [#&#8203;1329](TwiN/gatus#1329)
- fix(ui): Handle refresh properly on SuiteDetails.vue by [@&#8203;TwiN](https://github.com/TwiN) in [#&#8203;1324](TwiN/gatus#1324)
- fix(key): Support `(`, `)`, `+` and `&` as name/group by [@&#8203;TwiN](https://github.com/TwiN) in [#&#8203;1340](TwiN/gatus#1340)

#### New Contributors

- [@&#8203;aaldebs99](https://github.com/aaldebs99) made their first contribution in [#&#8203;1335](TwiN/gatus#1335)

**Full Changelog**: <TwiN/gatus@v5.26.0...v5.27.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzUuNCIsInVwZGF0ZWRJblZlciI6IjQxLjEzNS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbWFnZSJdfQ==-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1792
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
@TwiN
Copy link
Owner Author

TwiN commented Oct 20, 2025

I decided to revert the support for ( and ) since it already worked. It's a shame that this will break some that were staying closely up-to-date with the latest Gatus version like you were, but for the greater good of the community, I'll revert it to minimize those impacted.

Thank you for bringing this to my attention @markormesher, this kind of situation where you lose your history is definitely not the kind of experience I want people to have with Gatus :/

TwiN added a commit that referenced this pull request Oct 20, 2025
@TwiN
fix(key): Revert support for ( and ) as name/group, as they already w…
17c35e2 
…orked before

Relevant: #1340
@TwiN TwiN mentioned this pull request Oct 20, 2025
Merged
2 tasks
TwiN added a commit that referenced this pull request Oct 20, 2025
@TwiN
fix(key): Revert support for ( and ) as name/group, as they already w…
d24c66c 
…orked before (#1356)

Relevant: #1340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/api Related to the REST API area/ui Related to the user interface bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TwiN @amai2012 @markormesher