feat(client): Add ssh private-key support #1390
Merged
+92
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwiN
approved these changes
Nov 16, 2025
TwiN
changed the title
Owner
|
Excellent work! I'd appreciate a test for the private key, as you've suggested, though, and then we're good to go! No need to make it super complex. |
Contributor
Author
|
I looked into what we could be testing here. I've added a few cases to the existing config testing. But I can't think of a way to implement proper integration testing. Password-only could maybe be verified using https://test.rebex.net/ but can't think of a decent way to test private key auth. |
TwiN
approved these changes
Nov 18, 2025
Contributor
Author
|
@TwiN I think the tests failed due to GitHub facing issues. Could you try re-running the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1257
Summary
Adds support for using an unencrypted SSH key for SSH endpoint testing. Closes #1257 . I don't know if I should be adding a separate test for private-key, please let me know if I should :)
Checklist
README.md, if applicable.