feat(ui): Add custom theme support #1461
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default colors should be validated in unit tests
Can be used later if validation for type is extended and in unit tests to valiate default config once during testing and not always at runtime
github-actions
bot
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have put together a prototype based on #1445 to test the feasibility of implementing it configurable themes.
The current implementation allows to configure multiple themes in the backend which replace a template placeholder in the embedded html file served to the clients. The user can then select their preferred color theme via the settings menu.
Maybe the theme menu could replace the dark/light theme button entirely. So that for each theme it can be configured whether it is dark or light and the default config provides one for each.
Closes #1444
TODO
Checklist
README.md, if applicable.