feat(altering): Ntfy click link placeholder support #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythonGermany
commented
Dec 21, 2025
Comment on lines
+174
to
+183
| func resolveEndpointPlaceholders(data string, ep *endpoint.Endpoint) string { | ||
| placeholders := map[string]string{ | ||
| "[ENDPOINT_URL]": ep.URL, | ||
| "[ENDPOINT_KEY]": ep.Key(), | ||
| } | ||
| for placeholder, value := range placeholders { | ||
| data = strings.ReplaceAll(data, placeholder, value) | ||
| } | ||
| return data | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if there is a need or interest for more supported placeholders for this and other alert providers. In case there is it would probably make sense to move this out to a file that is shared by all providers and implement it in a more generic way.
This is especially the case if, like in the case of the click url. The part of the input data that is not replaced is static. It does not really make sense to search and replace the same placeholders each time an alert is sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simple addition to allow placeholders in the click link. This way it's easy to add a generic click link that links to the correct gatus endpoint details view:
Checklist
README.md, if applicable.