feat(alerting): Add support for Threema Gateway as an alerting provider (basic mode) #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
PythonGermany
force-pushed
the
add-threema-gateway-alert-provider
branch
5 times, most recently
from
5004226 to
c2d9183
Compare
PythonGermany
commented
Dec 22, 2025
Comment on lines
80
to
123
| type RecipientType int // TODO#1464: Maybe move to separate file in package to keep things organized | ||
|
|
||
| const ( | ||
| RecipientTypeInvalid RecipientType = iota | ||
| RecipientTypeId | ||
| RecipientTypePhone | ||
| RecipientTypeEmail | ||
| ) | ||
|
|
||
| func parseRecipientType(s string) RecipientType { | ||
| if val, ok := validRecipientTypes[s]; ok { | ||
| return val | ||
| } | ||
| return RecipientTypeInvalid | ||
| } | ||
|
|
||
| type Recipient struct { | ||
| Value string `yaml:"-"` | ||
| Type RecipientType `yaml:"-"` | ||
| } | ||
|
|
||
| var _ encoding.TextUnmarshaler = (*Recipient)(nil) | ||
| var _ encoding.TextMarshaler = (*Recipient)(nil) | ||
|
|
||
| func (r *Recipient) UnmarshalText(text []byte) error { | ||
| parts := strings.Split(string(text), ":") | ||
| switch { | ||
| case len(parts) > 2: | ||
| return ErrInvalidRecipientFormat | ||
| case len(parts) == 2: | ||
| if r.Type = parseRecipientType(parts[0]); r.Type == RecipientTypeInvalid { | ||
| return ErrInvalidRecipientType | ||
| } | ||
| r.Value = parts[1] | ||
| default: | ||
| r.Type = defaultRecipientType | ||
| r.Value = parts[0] | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (r Recipient) MarshalText() ([]byte, error) { | ||
| return []byte(r.Value), nil | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I have not seen a solution to preprocess/parse string values from the yaml config like this anywhere else in the repo. This new provider was a good playground to test it out.
I think applied to the condition system it could improve code quality (and maybe performance, I have not enough experience with go to know how much) significantly, because then parsing of the condition and runtime evaluation would be completely separated.
@TwiN What do you think about my approach?
PythonGermany
force-pushed
the
add-threema-gateway-alert-provider
branch
from
c2d9183 to
40dea85
Compare
PythonGermany
force-pushed
the
add-threema-gateway-alert-provider
branch
from
40dea85 to
acafd93
Compare
PythonGermany
force-pushed
the
add-threema-gateway-alert-provider
branch
from
91dadb9 to
fbef1ac
Compare
PythonGermany
changed the title
Contributor
Author
|
I have requested a Gateway ID from Threema. Once I have a working Gateway I will be able to test the alert provider against their API and once the tests are successful this PR will be ready. |
PythonGermany
force-pushed
the
add-threema-gateway-alert-provider
branch
from
5697f3c to
b36b2e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1464
Checklist
README.md, if applicable.