feat(logging): Switch to slog library #1472
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythonGermany
force-pushed
the
switch-logging-to-slog
branch
from
f847af9 to
d71ecf4
Compare
PythonGermany
force-pushed
the
switch-logging-to-slog
branch
from
d71ecf4 to
9bbdf76
Compare
PythonGermany
commented
Dec 24, 2025
| } | ||
| } | ||
| logr.Debugf("[security.callbackHandler] Subject %s is not in the list of allowed subjects", idToken.Subject) | ||
| slog.Debug("Subject not in allow-list", "subject", idToken.Subject) |
Contributor
Author
There was a problem hiding this comment.
TODO: Improve debug message to give more context -> What allow-list?
| } | ||
| s.suiteCache.Set(suiteKey, status) | ||
| logr.Debugf("[memory.InsertSuiteResult] Stored suite result for suiteKey=%s, total results=%d", suiteKey, len(status.Results)) | ||
| slog.Debug("Stored suite result", "key", suiteKey, "total_results", len(status.Results)) |
Contributor
Author
There was a problem hiding this comment.
TODO: Improve message?
| parsedDuration, err := time.ParseDuration(c.Query("duration")) | ||
| if err != nil { | ||
| logr.Errorf("[api.CreateExternalEndpointResult] Invalid duration from string=%s with error: %s", c.Query("duration"), err.Error()) | ||
| slog.Error("Invalid duration", "duration", c.Query("duration"), "error", err.Error()) |
Contributor
Author
There was a problem hiding this comment.
TODO: More message context needed?
| return c.Status(500).SendString(err.Error()) | ||
| } | ||
| logr.Infof("[api.CreateExternalEndpointResult] Successfully inserted result for external endpoint with key=%s and success=%s", c.Params("key"), success) | ||
| slog.Info("Successfully inserted result for external endpoint", slog.Group("result", "key", c.Params("key"), "success", success)) |
Contributor
Author
There was a problem hiding this comment.
TODO: Remove group test or apply in other places too?
logging/logging.go
Outdated
| "INFO": slog.LevelInfo, | ||
| "WARN": slog.LevelWarn, | ||
| "ERROR": slog.LevelError, | ||
| "FATAL": slog.LevelError, // slog does not have Fatal level, using Error instead TODO#1185: Check feasibility adding custom level FATAL to log handler or deprecate since its only used twice? |
Contributor
Author
There was a problem hiding this comment.
Is it ok that fatal log level does not exist anymore? I checked and it is possible to add custom levels, but it would obviously be convenient if we could just use the default ones.
logging/logging.go
Outdated
Comment on lines
43
to
50
| switch logSourceAsString { | ||
| case "", "FALSE": | ||
| break | ||
| case "TRUE": | ||
| logHandlerOptions.AddSource = true | ||
| default: | ||
| slog.Warn("Invalid log source value, defaulting to false", "provided", logSourceAsString) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Is this approach to disable source location logging by default and only enable different levels of verbosity for it via the GATUS_LOG_SOURCE and GATUS_LOG_TYPE env vars?
storage/store/store.go
Outdated
| if !initialized { | ||
| // This only happens in tests | ||
| logr.Info("[store.Get] Provider requested before it was initialized, automatically initializing") | ||
| slog.Info("Provider requested before it was initialized, automatically initializing") // TODO#1185 Why was/is this not warn level? |
Contributor
Author
There was a problem hiding this comment.
Why not warn level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1185
Checklist
README.md, if applicable.